-
Notifications
You must be signed in to change notification settings - Fork 47
remove deprecated TIMEOUT parameter from tasks #3100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit removes the deprecated TIMEOUT task parameter from the following tasks: - `verify-conforma-konflux-ta` - `verify-conforma-konflux-vsa-ta` - `verify-enterprise-contract` This commit also updates the associated documentation and README files. Ref: EC-1425 Signed-off-by: Rob Nester <rnester@redhat.com>
Review Summary by QodoRemove deprecated TIMEOUT parameter from Tekton tasks
WalkthroughsDescription• Remove deprecated TIMEOUT parameter from three Tekton tasks • Update task YAML definitions to remove parameter declaration • Update documentation and README files accordingly Diagramflowchart LR
A["Three Tekton Tasks"] -->|Remove TIMEOUT param| B["Task YAML Files"]
A -->|Remove TIMEOUT docs| C["Documentation Files"]
B --> D["Updated Task Definitions"]
C --> E["Updated Documentation"]
File Changes1. tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml
|
Code Review by Qodo
1. TIMEOUT param breaking removal
|
| description: Merge additional Rego variables into the policy data. Use syntax "key=value,key2=value2..." | ||
| default: "" | ||
|
|
||
| - name: TIMEOUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. Timeout param breaking removal 🐞 Bug ⛯ Reliability
• The PR removes the (deprecated) TIMEOUT param from the v0.1 Tekton Task specs, which is a backwards-incompatible contract change for any existing TaskRun/PipelineRun still providing TIMEOUT. • Because the tasks remain versioned as 0.1 and are used directly for bundle creation, this change ships “in place” rather than via a new task version, increasing upgrade risk for downstream users.
Agent Prompt
## Issue description
The deprecated `TIMEOUT` Tekton param was removed from multiple `0.1` task specs. Even if it was ignored at runtime, removing it from the spec is a breaking interface change for any PipelineRun/TaskRun still passing `TIMEOUT`.
## Issue Context
These tasks are bundled/published by reading the `tasks/.../0.1/*.yaml` files directly, so changing `0.1` in-place changes what downstream users consume.
## Fix Focus Areas
- tasks/verify-enterprise-contract/0.1/verify-enterprise-contract.yaml[119-131]
- tasks/verify-conforma-konflux-ta/0.1/verify-conforma-konflux-ta.yaml[112-126]
- tasks/verify-conforma-konflux-vsa-ta/0.1/verify-conforma-konflux-vsa-ta.yaml[123-139]
- docs/modules/ROOT/pages/release-process.adoc[93-103]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This commit removes the deprecated TIMEOUT task parameter from the following tasks:
verify-conforma-konflux-taverify-conforma-konflux-vsa-taverify-enterprise-contractThis commit also updates the associated documentation and README files.
Ref: EC-1425